chore: sync fork with upstream master - #4
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR syncs the fork with upstream finlabsuk/open-banking-connector (previously ~10 commits behind), bringing in upstream platform/runtime upgrades, database-provider changes, bank profile updates, and related model/converter improvements across the connector, web app, tests, and documentation.
Changes:
- Upgrade projects and container build/runtime to .NET 10, along with dependency bumps and API versioning updates.
- Remove SQLite support across configuration, persistence, startup wiring, and tests (moving integration tests to EF Core InMemory).
- Update bank profiles (HSBC/NatWest/Tide/Coutts) and extend JSON model handling (single-or-array DCR fields; VRP refund converter for v4.0).
Reviewed changes
Copilot reviewed 37 out of 37 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/OpenBanking.Library.Connector.UnitTests/OpenBanking.Library.Connector.UnitTests.csproj | Move unit tests to net10.0 and bump test dependencies. |
| test/OpenBanking.Library.Connector.IntegrationTests/Persistence/DomesticConsentRepoTests.cs | Remove obsolete integration test file tied to SQLite persistence. |
| test/OpenBanking.Library.Connector.IntegrationTests/OpenBanking.Library.Connector.IntegrationTests.csproj | Move integration tests to net10.0, add EF Core InMemory. |
| test/OpenBanking.Library.Connector.IntegrationTests/DbTest.cs | Replace in-memory SQLite with EF Core InMemory-backed context for tests. |
| test/OpenBanking.Library.Connector.Benchmarks/OpenBanking.Library.Connector.Benchmarks.csproj | Move benchmarks to net10.0. |
| test/OpenBanking.Library.Connector.BankTests/OpenBanking.Library.Connector.BankTests.csproj | Move bank tests to net10.0 and bump web/test dependencies. |
| test/OpenBanking.Library.Connector.BankTests/appsettings.Development.json | Remove SQLite connection string from bank test settings. |
| src/OpenBanking.WebApp.Connector/OpenBanking.WebApp.Connector.csproj | Move web app to net10.0 and bump web app/package versions. |
| src/OpenBanking.WebApp.Connector/Dockerfile | Update build/runtime images to .NET 10 and adjust build-stage env. |
| src/OpenBanking.WebApp.Connector/appsettings.Development.json | Remove SQLite connection string from web app dev settings. |
| src/OpenBanking.Library.Connector/Services/DbConnectionString.cs | Remove SQLite branch from provider-based connection string handling. |
| src/OpenBanking.Library.Connector/Persistence/SqliteDbContext.cs | Delete SQLite EF Core context implementation. |
| src/OpenBanking.Library.Connector/Persistence/DbProvider.cs | Remove Sqlite enum member. |
| src/OpenBanking.Library.Connector/OpenBanking.Library.Connector.csproj | Move connector library to net10.0 and update dependencies; drop EFCore.Sqlite. |
| src/OpenBanking.Library.Connector/Models/Persistent/Configuration/Management/BankRegistration.cs | Remove SQLite-specific DateTimeOffset conversion. |
| src/OpenBanking.Library.Connector/Models/Configuration/DatabaseSettings.cs | Remove SQLite defaults from provider-keyed settings dictionaries. |
| src/OpenBanking.Library.Connector/BankProfiles/Generators/TideGenerator.cs | Update Tide profile settings for registration endpoints. |
| src/OpenBanking.Library.Connector/BankProfiles/Generators/NatWestGenerator.cs | Update NatWest/Coutts sandbox behaviours and VRP refund options. |
| src/OpenBanking.Library.Connector/BankProfiles/Generators/HsbcGenerator.cs | Adjust HSBC VRP auth code grant behaviour defaults. |
| src/OpenBanking.Library.Connector.Web/OpenBanking.Library.Connector.Web.csproj | Move connector web library to net10.0. |
| src/OpenBanking.Library.Connector.GenericHost/OpenBanking.Library.Connector.GenericHost.csproj | Move generic host to net10.0 and bump hosting/telemetry deps. |
| src/OpenBanking.Library.Connector.GenericHost/HostedServices/StartupTasksHostedService.cs | Remove SQLite startup tasks and related wiring. |
| src/OpenBanking.Library.Connector.GenericHost/Extensions/ServiceCollectionExtensions.cs | Remove SQLite DI configuration branch. |
| src/OpenBanking.Library.BankApiModels/UkObRw/V4p0/NSwagVrp/Models/NSwagModels.cs | Apply VRP refund converter for v4.0 refund model property. |
| src/OpenBanking.Library.BankApiModels/UkObRw/V3p1p11/NSwagVrp/Models/NSwagModels.cs | Update VRP refund converter usage to generic converter. |
| src/OpenBanking.Library.BankApiModels/UkObDcr/V3p3/Models/OBRegistrationProperties1.cs | Add single-or-array JSON converter for specific DCR enum fields. |
| src/OpenBanking.Library.BankApiModels/UkObDcr/V3p2/Models/OBRegistrationProperties1.cs | Add single-or-array JSON converter for specific DCR enum fields. |
| src/OpenBanking.Library.BankApiModels/UkObDcr/V3p1/Models/OBRegistrationProperties1.cs | Add single-or-array JSON converter for specific DCR enum fields. |
| src/OpenBanking.Library.BankApiModels/OpenBanking.Library.BankApiModels.csproj | Move BankApiModels to net10.0 and bump dependencies. |
| src/OpenBanking.Library.BankApiModels/Json/SingleOrArrayConverter.cs | Introduce converter to accept single-value arrays for select DCR fields. |
| src/OpenBanking.Library.BankApiModels/Json/DomesticVrpRefundConverter.cs | Generalize VRP refund converter to a typed/generic converter and support new API shapes. |
| docs/configuration/database-settings.md | Update docs to remove SQLite provider references and defaults. |
| docs/apis/variable-recurring-payments/openapi-vrp.json | Bump published OpenAPI doc version to 21.0.0. |
| docs/apis/payment-initiation/openapi-pisp.json | Bump published OpenAPI doc version to 21.0.0. |
| docs/apis/management/openapi-manage.json | Bump published OpenAPI doc version to 21.0.0. |
| docs/apis/auth-contexts/openapi-auth.json | Bump published OpenAPI doc version to 21.0.0. |
| docs/apis/account-and-transaction/openapi-aisp.json | Bump published OpenAPI doc version to 21.0.0. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Alex (ahornsby-acquired)
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings the fork up to date with
finlabsuk/open-banking-connector, which it was ten commits behind. The merge was clean with no conflicts, as the fork carries no content changes of its own.DatabaseSettings,DbProviderand the integration tests.Details for AI reviewers
Upstream commits included
4e9afbeff6ac7f9ff48bf5d9fc13e04004bc206f1de29ed1f36650159b5162f47ce65a0246808d51Merge shape
The fork's five commits ahead of upstream are all merge commits from previous sync PRs;
git diff upstream/master...origin/masteris empty, so there is no fork-specific content to preserve. Merged with--no-ffrather than fast-forwarded because of those merge commits.Points worth attention
SqliteDbContextand drops aDbProviderenum member. Deployments run MongoDB, so no configuration should be affected, but anything pinningDbProviderby ordinal would be.test/OpenBanking.Library.Connector.IntegrationTests/Persistence/DomesticConsentRepoTests.csis deleted upstream as part of that removal.src/OpenBanking.WebApp.Connector/Dockerfile, so the next image build will differ substantially from the 18.2.0 currently deployed.SingleOrArrayConverteris new inOpenBanking.Library.BankApiModels/Json, applied toOBRegistrationProperties1across v3.1, v3.2 and v3.3.Not included
A separate commit adding the GCP Artifact Registry push to the web app workflow is held back from this branch, pending a token with the
workflowscope. It will follow as its own PR.